fix: write object to the correct urn when moving from another storage to object store #46013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
4 tasks
icewind1991
force-pushed
the
obj-store-move-from-storage-preserve-fileid
branch
from
28c3f45
to
23c72c0
Compare
… to object store Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
obj-store-move-from-storage-preserve-fileid
branch
from
23c72c0
to
ae77cde
Compare
come-nc
reviewed
Jun 24, 2024
| try { | ||
| $this->writeStream($targetInternalPath, $sourceStorage->fopen($sourceInternalPath, 'r'), $sourceCacheEntry->getSize()); | ||
| } catch (\Exception $e) { | ||
| $this->getCache()->remove($targetInternalPath); |
There was a problem hiding this comment.
Should we also put back the file in the source cache on exceptions?
Here it’s lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
copyFromStorage+deleteapproach loads to the object being written to the wrong urn.See also #43660 for a description of the problem and alternate approach.