fix(dav): add missing database index for dav_shares #46036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
st3iny,
miaulalala,
hamza221 and
kesselb
|
Otherwise ... what? |
st3iny
reviewed
Jun 21, 2024
SebastianKrupinski
requested review from
Altahrim,
nickvergessen,
skjnldsv,
julien-nc and
tcitworld
as code owners
SebastianKrupinski
force-pushed
the
fix/issue-46015
branch
from
49d6e5d
to
73a059f
Compare
st3iny
reviewed
Jun 25, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kesselb
reviewed
Jun 25, 2024
|
/backport to stable29 |
Altahrim
reviewed
Jun 26, 2024
| @@ -471,6 +471,9 @@ public function changeSchema(IOutput $output, \Closure $schemaClosure, array $op | |||
| ]); | |||
| $table->setPrimaryKey(['id']); | |||
| $table->addUniqueIndex(['principaluri', 'resourceid', 'type', 'publicuri'], 'dav_shares_index'); | |||
| // modified on 2024-6-21 to add performance improving indices on new instances | |||
| $table->addIndex(['resourceid', 'type'], 'dav_shares_resourceid_type'); | |||
There was a problem hiding this comment.
I don't know if principaluri is used for searches, but if not, it could make sense to change the unique index instead of adding this new one:
$table->addUniqueIndex(['resourceid', 'type', 'principaluri', 'publicuri'], 'dav_shares_index');
SebastianKrupinski
force-pushed
the
fix/issue-46015
branch
from
2cdac28
to
7f37143
Compare
…and access Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com> Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com> Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com> Co-authored-by: Daniel <mail@danielkesselberg.de> Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com> Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/issue-46015
branch
from
7f37143
to
ff7e2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added missing database indexes for dav_shares table, (resourceid, type) and (recourseid, access)