Fix task processing input validation #46058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
approved these changes
Jun 24, 2024
julien-nc
force-pushed
the
fix/task-processing-input-validation
branch
from
cbfad3f
to
0593fbf
Compare
bigcat88
approved these changes
Jun 24, 2024
julien-nc
force-pushed
the
fix/task-processing-input-validation
branch
from
0593fbf
to
b5b6a72
Compare
julien-nc
force-pushed
the
fix/task-processing-input-validation
branch
from
b5b6a72
to
79164fb
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/task-processing-input-validation
branch
from
79164fb
to
7e1dd0b
Compare
… input/output keys that are not in the task values Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
|
@marcelklehr I had to adjust again to make the tests pass. As the purpose of this method is to remove keys, this fix seems fine to me. But do we actually check that all the input shape fields are defined in the task? If not, do you think it should be done? |
Yes, the validateInput and validateOutput methods check this |
marcelklehr
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was dropping some optional inputs.