Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): Also set the expiration date timezone during validation #46097

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 25, 2024

This is needed as we want to store the difference between the server's and the user's timezones.

Follow-up of #43428

@artonge artonge requested review from Altahrim and Fenn-CS June 25, 2024 10:24
@artonge artonge self-assigned this Jun 25, 2024
@artonge artonge added bug 3. to review Waiting for reviews feature: sharing php Pull requests that update Php code labels Jun 25, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jun 25, 2024
@artonge
Copy link
Contributor Author

artonge commented Jun 25, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Jun 25, 2024

/backport to stable28

@artonge artonge force-pushed the artonge/fix/dont_override_expiration_date branch 4 times, most recently from 5630c33 to 0f56fb4 Compare June 25, 2024 13:07
@artonge artonge changed the title Do not update the timezone of the expiration date when validating it fix(files_sharing): Also set the expiration date timezone during validation Jun 25, 2024
Copy link
Contributor

@Fenn-CS Fenn-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

…s timezone

This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/dont_override_expiration_date branch from 0f56fb4 to f5fd6c8 Compare June 26, 2024 10:49
@artonge artonge merged commit ba30695 into master Jun 26, 2024
166 checks passed
@artonge artonge deleted the artonge/fix/dont_override_expiration_date branch June 26, 2024 14:40
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: sharing php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants