fix: Add acceptShare as an interface
#46099
Open
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was commented out because at that time no other share provider supported the `acceptShare` method. Today it is the same no other provider supports it, but we should make it discoverable by adding it to the public API as an additional interface. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * @param IShare $share | ||
| * @param string $recipient | ||
| * @return IShare The share object | ||
| * @since 17.0.0 |
There was a problem hiding this comment.
Suggested change
| * @since 17.0.0 | |
| * @since 30.0.0 |
| * | ||
| * @since 30.0.0 | ||
| */ | ||
| interface IShareProviderSupportsAccept { |
There was a problem hiding this comment.
Could also:
Suggested change
| interface IShareProviderSupportsAccept { | |
| interface IShareProviderSupportsAccept extends IShareProvider { |
but that might only work atm while it's still linear?
| @@ -1018,6 +1019,7 @@ public function acceptShare(IShare $share, string $recipientId): IShare { | |||
| // TODO FIX ME | |||
There was a problem hiding this comment.
check for the new interface instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was commented out because at that time no other share provider supported the
acceptSharemethod. Today it is the same no other provider supports it, but we should make it discoverable by adding it to the public API as an additional interface.5 years after no other provider supports it, so maybe an additional interface would be better like done here?
Ref: #16828 (comment)
Checklist