Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editLocallyAction): Handle possible no local client scenario #46452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Jul 11, 2024

Summary

Resolves: #46438

Screencast

Screencast.from.2024-07-12.01-43-50.webm

TODO

  • Screenshots ?

@Fenn-CS Fenn-CS force-pushed the feat/46438/provide-feedback-edit-locally branch 8 times, most recently from a113d41 to c45e176 Compare July 12, 2024 00:41
@Fenn-CS Fenn-CS marked this pull request as ready for review July 12, 2024 00:41
@Fenn-CS Fenn-CS requested a review from skjnldsv as a code owner July 12, 2024 00:41
@Fenn-CS Fenn-CS requested review from a team, Pytal and sorbaugh and removed request for a team July 12, 2024 00:45
@Fenn-CS Fenn-CS added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 12, 2024
@Fenn-CS Fenn-CS enabled auto-merge July 12, 2024 00:46
@Fenn-CS Fenn-CS force-pushed the feat/46438/provide-feedback-edit-locally branch 3 times, most recently from ce7055b to 0ef4ad3 Compare July 12, 2024 14:41
Resolves: #46438

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the feat/46438/provide-feedback-edit-locally branch from 0ef4ad3 to 43aade3 Compare July 15, 2024 11:22
@Fenn-CS Fenn-CS requested review from Pytal and susnux July 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Workaround when selecting "edit locally" as an option
3 participants