fix(files): Update displayname on rename #46474
Open
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jul 12, 2024
Nextcloud always sets the `displayname` attribute, with fallback to the basename. So if we move or rename a file the old displayname will still be used as we only update the basename but not the displayname. Safest would be refetch, but if displayname and basename is equal we can safe one request and set the displayname to the new basename. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-renaming
branch
from
0efc694
to
374e6e9
Compare
|
BTW I am not sure if we should do that here in server or better in the Node class, as this also needs to be updated on move |
Fenn-CS
approved these changes
Jul 15, 2024
susnux
added a commit
to nextcloud-libraries/nextcloud-files
that referenced
this pull request
Jul 15, 2024
The displayname is always set by Nextcloud, so if it is not a custom one it is set to the basename. This means on move (and rename) we need to update the displayname. This is an alternative to nextcloud/server#46474 We should consider making the displayname a top-level attribute like basename. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nextcloud always sets the
displaynameattribute, with fallback to the basename. So if we move or rename a file the old displayname will still be used as we only update the basename but not the displayname. Safest would be re-fetch, but if displayname and basename is equal we can safe one request and set the displayname to the new basename.Checklist