fix(theming): enforce theme should still provide dark as fallback #46504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This was referenced Jul 13, 2024
susnux
approved these changes
Jul 15, 2024
ShGKme
approved these changes
Jul 15, 2024
| @@ -28,7 +28,7 @@ public function __construct( | |||
| private LoggerInterface $logger, | |||
| private DefaultTheme $defaultTheme, | |||
| LightTheme $lightTheme, | |||
| DarkTheme $darkTheme, | |||
| private DarkTheme $darkTheme, | |||
There was a problem hiding this comment.
Because it is now used in getThemesmethod, before this was not a class attribute but just a constructor parameter (it is now promoted as a private class attribute).
|
Backport? |
|
/backport to stable29 |
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered from
@nextcloud/vueto 8.14.0 viewer#2358Otherwise apps cannot enforce some areas of their UI to be dark, like the Modal component which is always dark.
Here is the result otherwise: