refactor: Migrate filename validation from Storage and Util to FilenameValidator
#46538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/use-filename-validator
branch
from
09544aa
to
e42547e
Compare
3 tasks
susnux
force-pushed
the
fix/use-filename-validator
branch
from
e42547e
to
abc3227
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -355,10 +355,13 @@ | |||
| return $this->info->getOwner(); | |||
| } | |||
|
|
|||
| protected function verifyPath() { | |||
| protected function verifyPath(?string $path = null) { | |||
Check notice
Code scanning / Psalm
MissingReturnType Note
susnux
force-pushed
the
fix/use-filename-validator
branch
from
abc3227
to
e00f6ad
Compare
susnux
added
bug
3. to review
skjnldsv
approved these changes
Jul 16, 2024
yemkareems
approved these changes
Jul 16, 2024
artonge
approved these changes
Jul 16, 2024
…meValidator` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…o `FilenameValidator` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/use-filename-validator
branch
from
e00f6ad
to
52c92e4
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/use-filename-validator
branch
from
52c92e4
to
322b394
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
verifyPathlogic from common storage toFilenameValidatorOCP\UtiltoFilenameValidatorand remove the loong depreated method.In a follow up I will remove to usage of OC in OCA\Files but this requires a library update (so we can use capabilities instead of the initial state).
Checklist