Fix mentioned user not clickable after posting or editing a comment #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The contactsMenu plugin was called on avatar elements from _postRenderItem, which is called when a new comment is added to the collection. Due to this contactsMenu was not called when messages were edited; when a new comment is posted _postRenderItem is called, but at that time the "mentions" attribute is not filled yet, so "@username" is not replaced by avatars in the message and thus contactsMenu has no avatars to be called on. Calling contactsMenu was moved to a new method, _postRenderMessage, which is called from _postRenderItem and from the success callback when fetching the model in _onSubmitSuccess (which replaces "@username" by avatars in the message after posting or editing a comment). Fixes #4555 Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
@danxuliu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @MorrisJobke and @jancborchardt to be potential reviewers. |
MorrisJobke
requested review from
rullzer,
nickvergessen,
MorrisJobke,
georgehrke and
blizzz
MorrisJobke
approved these changes
May 8, 2017
nickvergessen
added
4. to release
rullzer
deleted the
fix-mentioned-user-not-clickable-after-posting-or-editing-a-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contactsMenu plugin was called on avatar elements from
_postRenderItem, which is called when a new comment is added to the collection. Due to this contactsMenu was not called when messages wereedited; when a new comment is posted
_postRenderItemis called, but at that time the mentions attribute is not filled yet, so @username is not replaced by avatars in the message and thus contactsMenu has no avatars to be called on.Calling contactsMenu was moved to a new method,
_postRenderMessage, which is called from_postRenderItemand from the success callback when fetching the model in_onSubmitSuccess(which replaces @username by avatars in the message after posting or editing a comment).Fixes #4555