Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reset password link #4809

Merged
merged 2 commits into from May 12, 2017
Merged

Disable reset password link #4809

merged 2 commits into from May 12, 2017

Conversation

nickvergessen
Copy link
Member

Fix #4008

Downstream 27676

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone May 11, 2017
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @LukasReschke and @j-ed to be potential reviewers.

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that also needs to be added to \OC\Core\Controller\LostController because that is otherwise only cosmetics and not really a good security measure.

@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #4809 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4809      +/-   ##
============================================
- Coverage     54.21%   54.21%   -0.01%     
- Complexity    22147    22148       +1     
============================================
  Files          1363     1363              
  Lines         84789    84791       +2     
  Branches       1322     1322              
============================================
  Hits          45971    45971              
- Misses        38818    38820       +2
Impacted Files Coverage Δ Complexity Δ
config/config.sample.php 0% <ø> (ø) 0 <0> (ø) ⬇️
core/Controller/LoginController.php 76.92% <0%> (-1.21%) 38 <0> (+1)

@nickvergessen
Copy link
Member Author

@LukasReschke done

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@LukasReschke LukasReschke merged commit 4f752ed into master May 12, 2017
@LukasReschke LukasReschke deleted the downstream-27676 branch May 12, 2017 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants