Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix objectstore rename" #4872

Merged
merged 1 commit into from
May 15, 2017
Merged

Revert "fix objectstore rename" #4872

merged 1 commit into from
May 15, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented May 15, 2017

This reverts commit 5334a3d.

Few things:

  1. If we don't want a storage to use part files we should not use this magic but use https://github.com/nextcloud/server/blob/master/lib/public/Files/Storage.php#L462
  2. I don't get why using this on ObjectStorage is needed. The rename is cheap (just in the DB) and avoids nasty things (like creating the version directly etc).

@rullzer
Revert "fix objectstore rename"
cef2110 
This reverts commit 5334a3d.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 12.0 milestone May 15, 2017
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @MorrisJobke to be potential reviewers.

nickvergessen
nickvergessen approved these changes May 15, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 15, 2017
@MorrisJobke MorrisJobke merged commit 3bd5132 into master May 15, 2017
@MorrisJobke MorrisJobke deleted the os-rename branch May 15, 2017 14:13
@gmright2 gmright2 mentioned this pull request Oct 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rullzer @mention-bot @nickvergessen @icewind1991 @MorrisJobke