Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show client info, when the app is disabled #5225

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review Waiting for reviews bug labels Jun 2, 2017
@nickvergessen nickvergessen added this to the Nextcloud 12.0.1 milestone Jun 2, 2017
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better be moved as personal settings page to the app in general, but … OK for now. Code looks good.

@@ -301,6 +301,7 @@
</form>


<?php if(OC_APP::isEnabled('firstrunwizard')) {?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to pass it as a template variable instead of using (legacy) functions in the template

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved this.
This is stable12 want to keep it simple.
For 13 i will move it to the app directly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to my todo list

@schiessle schiessle merged commit a61aabe into stable12 Jun 2, 2017
@schiessle schiessle deleted the no-client-info-without-firstrunwizard branch June 2, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants