-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quota to the files view #5305
Conversation
That was also our idea to put in down there. |
👎 ... You'll get a nice overview there, and we need this bar for the quota-buttons ( |
@MariusBluem oh okay. I don't know that, I don't use external storage :) |
Codecov Report
@@ Coverage Diff @@
## master #5305 +/- ##
=========================================
Coverage ? 54.14%
Complexity ? 22313
=========================================
Files ? 1381
Lines ? 85470
Branches ? 1325
=========================================
Hits ? 46275
Misses ? 39195
Partials ? 0
|
|
It is only in the branded apps on the top. :/ |
Why is it there for the normal version? This should be the "quota" type link from the external sites app and if this is not configured should not show up at all. |
See comment above |
Ok, so TL;DR what to change here before we can merge? ;) |
I will have a look to bring the externals app link into this |
What about simply using the first quota-link? @nickvergessen |
Will this PR also recognize the total amount of storage even if a quota isn't set, or will it still say "unlimited"? |
I removed the "of Unlimited" because I think it's useless, the blue bar however will should the percentage of the total available space |
I can only move it to the bottom when the box shall be below the deleted files link. Or make it the last item in the list. Is that okay? @jancborchardt |
I'd say let's put it last in the list. If we add it to the sticky part on the bottom, it will obscire the list too much on mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool stuff 🚀
This is needed to put it to the bottom: position: fixed !important;
bottom: 88px;
width: inherit !important;
background-color: #fff;
border-right: 1px solid #eee;
z-index:1; We also need to update the padding of the last element in the upper menu to have a padding of 44px by default: .app-files #app-navigation > ul li:nth-last-child(2) {
margin-bottom: 44px;
} and update the same rule in the trashbin to have .app-files #app-navigation > ul li:nth-last-child(2) {
margin-bottom: 44px;
} let me update the CSS. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
df5a8d9
to
27690e0
Compare
Rebased on master for test execution. |
@MorrisJobke Mind committing your patch for #5305 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the quota bar to not have an icon 👍
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
6328dc7
to
4a256aa
Compare
Looked better before with the icon, in line with the others. Right now it might even be confused as being info of the Deleted files entry. |
The quota bar is something different then the sidebar items (deleted files, ...). It is a static element and not something you should/can click on ;) |
It absolutely should be possible to click on in the future so you see how the storage is used. Like on iOS or Android where you see which apps / filetypes use most. |
Yeah but that is not part of todays story. Currently 4 people prefer without the icon, and only you prefer with it. Do your thing, or merge. This needs to be merged and backported by friday, please take care of this @jancborchardt if you block this now. |
I did do it like this and it was overwritten. But sure, do design by voting. |
But currently on iOS and Android this item also doesn't have an item. So I think this is more in line with that, but as always: we can improve on this if the icon is the better way: sure - we should go for it. Let's see what the users say. |
I will take care of the backport. |
Nice work here! 👍 |
cc @jancborchardt apply beautification 😸