-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style of link share password input view #5562
Conversation
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @LukasReschke and @prastut to be potential reviewers. |
PS: the width problem is Firefox only it seems. Looks good in Chromium.. |
have the same issue on Firefox, Chromium looks good. |
Hm … can’t seem to figure it out even though it should be an easy fix. @pixelipo @andreasjacobsen93 @juliushaertl I’m sure you can help with this browser inconsistency issue? :D |
@jancborchardt @nickvergessen it looks like the content (input fields inside the
10px is way less than the width of the button, so it doesn't fit. I don't know why Chromium allows it, but I would guess it's a "bug" in Chromium 😉 |
@pixelipo sorry, just saw it now. :) Do you know what a cross-browser solution would be then? |
Status? @jancborchardt |
Any more ideas here @skjnldsv @juliushaertl? |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
eb52823
to
7e4417e
Compare
@jancborchardt Done! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
7e4417e
to
4faa562
Compare
Edited the fix, I found the real issue. Firefox have a min-width set to auto by default. Nobody really knows why but it breaks flex in a lot of situations! :) @nextcloud/designers please review! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works nicely 👍
Ignore the one failing CI job - my fault there. |
Before:
After:
Please review @nickvergessen @nextcloud/sharing