Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style of link share password input view #5562

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Conversation

jancborchardt
Copy link
Member

Before:

After:
screenshot from 2017-06-29 16-34-35 screenshot from 2017-06-29 16-34-47

Please review @nickvergessen @nextcloud/sharing

@jancborchardt jancborchardt added 3. to review Waiting for reviews backport-request bug design Design, UI, UX, etc. labels Jun 29, 2017
@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Jun 29, 2017
@mention-bot
Copy link

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @LukasReschke and @prastut to be potential reviewers.

@nickvergessen
Copy link
Member

Your screenshot looks good, however for me it looks like this now:

nextcloud_-_2017-06-29_16 53 56

So font is black instead of white (theme color related? #07CBDF = jup, changing it to something darker makes the font go white. so the login image needs the same brightness as the theming color)
And the width is off?

@nickvergessen
Copy link
Member

PS: the width problem is Firefox only it seems. Looks good in Chromium..

@schiessle
Copy link
Member

PS: the width problem is Firefox only it seems. Looks good in Chromium..

have the same issue on Firefox, Chromium looks good.

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 3, 2017
@jancborchardt
Copy link
Member Author

Hm … can’t seem to figure it out even though it should be an easy fix. @pixelipo @andreasjacobsen93 @juliushaertl I’m sure you can help with this browser inconsistency issue? :D

@pixelipo
Copy link
Contributor

pixelipo commented Jul 6, 2017

@jancborchardt @nickvergessen it looks like the content (input fields inside the <fieldset>) require more space than container form provides. Problem is here:

#body-login input[type="password"] {
    width: calc(100% - 10px);
}

10px is way less than the width of the button, so it doesn't fit. I don't know why Chromium allows it, but I would guess it's a "bug" in Chromium 😉

@jancborchardt
Copy link
Member Author

@pixelipo sorry, just saw it now. :) Do you know what a cross-browser solution would be then?

@nickvergessen
Copy link
Member

Status? @jancborchardt

@jancborchardt jancborchardt self-assigned this Sep 17, 2017
@jancborchardt
Copy link
Member Author

Any more ideas here @skjnldsv @juliushaertl?

@skjnldsv skjnldsv self-assigned this Sep 17, 2017
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@skjnldsv
Copy link
Member

@jancborchardt Done! :)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member

Edited the fix, I found the real issue. Firefox have a min-width set to auto by default. Nobody really knows why but it breaks flex in a lot of situations! :)

@nextcloud/designers please review! :)

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 19, 2017
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works nicely 👍

@MorrisJobke
Copy link
Member

Ignore the one failing CI job - my fault there.

@nickvergessen nickvergessen merged commit e43400e into master Sep 20, 2017
@nickvergessen nickvergessen deleted the link-password-style branch September 20, 2017 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing password input for visitors is wrongly styled
8 participants