New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Show warning if PHP 7.2 is used #5792

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@LukasReschke
Member

LukasReschke commented Jul 19, 2017

Ref #5791

@LukasReschke LukasReschke added this to the Nextcloud 12.0.1 milestone Jul 19, 2017

Show warning if PHP 7.2 is used
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 21, 2017

Codecov Report

Merging #5792 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5792      +/-   ##
==============================================
- Coverage       54.09%   54.09%   -0.01%     
+ Complexity      22445    22440       -5     
==============================================
  Files            1380     1380              
  Lines           85830    85820      -10     
  Branches         1329     1329              
==============================================
- Hits            46434    46421      -13     
- Misses          39396    39399       +3
Impacted Files Coverage Δ Complexity Δ
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/encryption/lib/Util.php 77.55% <0%> (-14.29%) 16% <0%> (ø)
apps/encryption/lib/Crypto/Encryption.php 83.43% <0%> (-0.5%) 55% <0%> (-2%)
config/config.sample.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Mail/Mailer.php 64.17% <0%> (+1.51%) 22% <0%> (-3%) ⬇️
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

codecov bot commented Jul 21, 2017

Codecov Report

Merging #5792 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable12    #5792      +/-   ##
==============================================
- Coverage       54.09%   54.09%   -0.01%     
+ Complexity      22445    22440       -5     
==============================================
  Files            1380     1380              
  Lines           85830    85820      -10     
  Branches         1329     1329              
==============================================
- Hits            46434    46421      -13     
- Misses          39396    39399       +3
Impacted Files Coverage Δ Complexity Δ
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/encryption/lib/Util.php 77.55% <0%> (-14.29%) 16% <0%> (ø)
apps/encryption/lib/Crypto/Encryption.php 83.43% <0%> (-0.5%) 55% <0%> (-2%)
config/config.sample.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/js/js.js 61.94% <0%> (+0.11%) 0% <0%> (ø) ⬇️
lib/private/Mail/Mailer.php 64.17% <0%> (+1.51%) 22% <0%> (-3%) ⬇️
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️
@MorrisJobke

I added the same check to console.php and tested it 👍

@rullzer rullzer merged commit 4165d5b into stable12 Jul 21, 2017

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@rullzer rullzer deleted the stable12-prevent-php7.2-usage branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment