Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable12] dont send invitations for past events #5841

Merged
merged 2 commits into from
Aug 30, 2017
Merged

[stable12] dont send invitations for past events #5841

merged 2 commits into from
Aug 30, 2017

Conversation

georgehrke
Copy link
Member

backport of #5304

@georgehrke
don't send invitation emails for past events
702d13c 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
Sabre/VObject returns DateTimeImmutable, not a simple DateTime
7b113bb 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Jul 23, 2017
@mention-bot
Copy link

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @rullzer to be potential reviewers.

@georgehrke georgehrke mentioned this pull request Jul 23, 2017
Merged
@jospoortvliet
Copy link
Member

jospoortvliet commented Jul 24, 2017 •
edited
Loading

Would be good to get this in 12.0.1... though that is late huh? @LukasReschke ?

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.2 milestone Aug 2, 2017
@ggeorgg
Copy link

ggeorgg commented Aug 22, 2017

I've tested this and it does what the title says. Invitations are not sent for past events anymore with this fix.

@ggeorgg ggeorgg mentioned this pull request Aug 22, 2017
Closed
tcitworld
tcitworld approved these changes Aug 27, 2017
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. 👍

apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
/** @var ITimeFactory */
private $timeFactory;

const MAX_DATE = '2038-01-01';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this date ? Isn't this too much ?

@MorrisJobke MorrisJobke merged commit 6704e89 into stable12 Aug 30, 2017
@MorrisJobke MorrisJobke deleted the bugfix-stable12/2855/dont_send_invitations_for_past_events branch August 30, 2017 19:01
@tschlotfeldt
Copy link

I think these this not the right solution for the case that a user is importing his calendar(s) as in #2855.
This makes switching from another calendar server to NextCloud not easy. Still all the attendees of future appointments will get an invitation again. This would be very annoying.

@tcitworld tcitworld mentioned this pull request Sep 24, 2017
Closed
@georgehrke
Copy link
Member Author

@tschlotfeldt See nextcloud/calendar#576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@tcitworld tcitworld tcitworld approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@georgehrke @mention-bot @jospoortvliet @ggeorgg @tschlotfeldt @MorrisJobke @tcitworld