New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] fix searchbox background #623

Merged
merged 3 commits into from Jul 30, 2016

Conversation

Projects
None yet
5 participants
@jancborchardt
Member

jancborchardt commented Jul 28, 2016

@MorrisJobke can you fix the unit tests? I don’t know which exact features are in there to be tested at that point, like which have been backported. Also cc @juliushaertl for info since some of the inversion stuff etc was done by you. :)

Please review @nextcloud/designers @Mar1u5 @Bugsbane @williambargent @juliushaertl @MorrisJobke

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 28, 2016

@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @MorrisJobke and @PVince81 to be potential reviewers

mention-bot commented Jul 28, 2016

@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @MorrisJobke and @PVince81 to be potential reviewers

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Jul 28, 2016

Member

@MorrisJobke assigned you to check for the tests. :)

Member

jancborchardt commented Jul 28, 2016

@MorrisJobke assigned you to check for the tests. :)

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 28, 2016

Member

@MorrisJobke assigned you to check for the tests. :)

I'm not your minion: You could at least check the output and fix the easy stuff https://travis-ci.org/nextcloud/server/jobs/147977236#L297 first. Then if you don't know how to fix the rest I could help you.

Member

MorrisJobke commented Jul 28, 2016

@MorrisJobke assigned you to check for the tests. :)

I'm not your minion: You could at least check the output and fix the easy stuff https://travis-ci.org/nextcloud/server/jobs/147977236#L297 first. Then if you don't know how to fix the rest I could help you.

@jancborchardt jancborchardt removed their assignment Jul 29, 2016

@MorrisJobke MorrisJobke changed the title from WIP [stable9] fix searchbox background to [stable9] fix searchbox background Jul 29, 2016

@$this->assertEquals($expected, $this->themingController->getStylesheet());
}
public function testGetStylesheetWithOnlyColorInvert() {

This comment has been minimized.

@juliushaertl

juliushaertl Jul 29, 2016

Member

This is a duplicate unit test, as the color inverting was not backported to Nc9, but I guess this doesn't hurt.

@juliushaertl

juliushaertl Jul 29, 2016

Member

This is a duplicate unit test, as the color inverting was not backported to Nc9, but I guess this doesn't hurt.

@$this->assertEquals($expected, $this->themingController->getStylesheet());
}
public function testGetStylesheetWithAllCombinedInverted() {

This comment has been minimized.

@juliushaertl

juliushaertl Jul 29, 2016

Member

same as above.

@juliushaertl

juliushaertl Jul 29, 2016

Member

same as above.

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Jul 29, 2016

Member

I guess we can keep the unit tests, even if they are kind of duplicate.

👍 from my side

Member

juliushaertl commented Jul 29, 2016

I guess we can keep the unit tests, even if they are kind of duplicate.

👍 from my side

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Jul 30, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Jul 30, 2016

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 393f7f8 into stable9 Jul 30, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable9-fix-searchbox-background branch Jul 30, 2016

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Jul 30, 2016

Member

Thanks for your help @MorrisJobke! :) Maybe a talk on getting into writing tests at the Nextcloud Conference would be cool ;)

Member

jancborchardt commented Jul 30, 2016

Thanks for your help @MorrisJobke! :) Maybe a talk on getting into writing tests at the Nextcloud Conference would be cool ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment