Show "Uploading..." in web UI for long uploads #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Aug 23, 2017
If the estimated upload time is bigger than 4 hours it shows the text "Uploading..." because the time then doesn't give any good hint to the user anyways. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-uploading-message
branch
from
c2ee2de
to
591dda2
Compare
|
Simple enough fix :) 👍 |
danxuliu
approved these changes
Aug 23, 2017
|
One thing to check though is that the blue bar gets filled and doesn't drop back to a small value. |
MorrisJobke
added
4. to release
jancborchardt
approved these changes
Aug 23, 2017
Will fix in a separate PR. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
Because @jancborchardt asked for it: I added a commit to replace the ... with … (ellipsis), but will not backport this to stable12. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the estimated upload time is bigger than 4 hours it shows the text "Uploading..." because the time then doesn't give any good hint to the user anyways.
cc @oparoz