Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the wrapper to get the parameters which was added in #6369 #6569

Merged
merged 1 commit into from Sep 19, 2017
Merged

Use the wrapper to get the parameters which was added in #6369 #6569

merged 1 commit into from Sep 19, 2017

Conversation

nickvergessen
Copy link
Member

Fix #6567

@nickvergessen
Use the wrapper to get the parameters which was added in #6369
10c7ecb 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Sep 19, 2017
@nickvergessen nickvergessen mentioned this pull request Sep 19, 2017
Merged
@nickvergessen
Copy link
Member Author

Backport in #6570

@codecov
Copy link

codecov bot commented Sep 19, 2017 •
edited

Codecov Report

Merging #6569 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #6569      +/-   ##
============================================
- Coverage     53.12%   53.12%   -0.01%     
  Complexity    22547    22547              
============================================
  Files          1411     1411              
  Lines         87648    87648              
  Branches       1340     1340              
============================================
- Hits          46565    46564       -1     
- Misses        41083    41084       +1
Impacted Files Coverage Δ Complexity Δ
apps/comments/lib/Activity/Provider.php 5.21% <0%> (ø) 26 <0> (ø) ⬇️
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)

@LukasReschke LukasReschke merged commit 916a1b5 into master Sep 19, 2017
@LukasReschke LukasReschke deleted the fix-comments-activity-error branch September 19, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification feature: comments
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @rullzer @LukasReschke