Add Updates section to app management #6739

juliushaertl · 2017-10-03T13:09:14Z

Add updates section to the apps management (fixes #838)

Partly fixes #301 since it removes the notification in the header and adds a badge with the update count to the sidebar.

codecov · 2017-10-03T13:32:29Z

Codecov Report

Merging #6739 into master will decrease coverage by 0.05%.
The diff coverage is 35.21%.

@@             Coverage Diff             @@
##             master   #6739      +/-   ##
===========================================
- Coverage     53.05%     53%   -0.06%     
+ Complexity    22650   22614      -36     
===========================================
  Files          1430    1422       -8     
  Lines         88062   88023      -39     
  Branches       1343    1346       +3     
===========================================
- Hits          46725   46658      -67     
- Misses        41337   41365      +28

Impacted Files	Coverage Δ	Complexity Δ
settings/templates/apps.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/private/legacy/app.php	`54.23% <100%> (+0.91%)`	`218 <0> (-4)`	⬇️
settings/js/apps.js	`24.57% <30.23%> (+0.17%)`	`0 <0> (ø)`	⬇️
settings/Controller/AppSettingsController.php	`19.2% <52.38%> (+3.04%)`	`71 <5> (+6)`	⬆️
...es_sharing/lib/Controller/ShareesAPIController.php	`64.47% <0%> (-5.53%)`	`114% <0%> (+90%)`
apps/files/templates/list.php	`0% <0%> (ø)`	`0% <0%> (ø)`	⬇️
core/js/contactsmenu.js	`91.97% <0%> (ø)`	`0% <0%> (ø)`	⬇️
apps/files/templates/simplelist.php	`0% <0%> (ø)`	`0% <0%> (ø)`	⬇️
core/templates/layout.user.php	`0% <0%> (ø)`	`0% <0%> (ø)`	⬇️
... and 15 more

skjnldsv

After an update, the counter is set to -1! :)
Otherwise, great addition! Works nicely!

juliushaertl · 2017-10-03T14:50:45Z

@skjnldsv Thanks. Fixed with the latest commit.

skjnldsv

Message for no updates available is not good! :)

Also, I think we should hide the section if no updates are available :)

juliushaertl · 2017-10-03T16:16:31Z

@skjnldsv I'd prefer to keep the section even if it is empty. That way users might remember where to check for updates if they come back.

This is how it looks now, when there are no updates available:

skjnldsv · 2017-10-03T16:21:20Z

Can you add a manual trigger button instead of the zero count then? I don't see why a user would click this section if the zero is clearly visible! :)

juliushaertl · 2017-10-03T17:01:03Z

Hm maybe we should hide it then. There is a background job for fetching updates and I don't think we need an option to manually check. Any other thoughts on that @nextcloud/designers

nickvergessen · 2017-10-04T09:17:38Z

settings/js/apps.js

 				$('#apps-categories').html(html);
 				$('#app-category-' + OC.Settings.Apps.State.currentCategory).addClass('active');
+				if (updateCategory.length === 1) {
+					console.log(updateCategory);


nickvergessen · 2017-10-04T09:22:18Z

Hm maybe we should hide it then.

I agree, hide the section when empty (just like play store and others do it as well)
Makes little sense to have it, when there are no updates pending

juliushaertl · 2017-10-04T12:26:33Z

@nickvergessen @skjnldsv Fixed. The updates category is now hidden. It will be shown if an update get available while the user is browsing the page.

jancborchardt · 2017-10-04T13:21:37Z

@juliushaertl Actually, and sorry I only realize this now – with »Show apps with available updates first« #6740 by you this seems to be not necessary anymore. :)

I would prefer if it’s nicely integrated simply by sorting up, and not with the additional view. It’s duplicated otherwie. Sorry for the late realization, but thanks for the two great pull requests! :) What do you think?

skjnldsv · 2017-10-04T13:35:41Z

@jancborchardt I don't mind the extra section. I find it easier to search what you need. Users can't directly know that the updates are on top of the list, while with the section, there is no confusion possible.

jancborchardt · 2017-10-04T14:15:50Z

Hm, then maybe we should add a heading, like for the bundles? I really think that we should keep the navigation lean and not list everything possible.

jancborchardt · 2017-10-04T14:17:58Z

Cause that will make the list clearer in general – also for »Enabled apps« and »Disabled apps«. Because currently they are sorted properly, but don’t have any section separation which would be nice. Then we could also simply cut those sidebar entries out and just have »Your apps«.

skjnldsv · 2017-10-04T14:19:15Z

Still disagree with that (sorry! 🙈). I dislike having to scroll to search. Restricting views are a big plus on this. I rather click to se that scroll x time to get to the section I need. I have a lot apps installed. :)

juliushaertl · 2017-10-04T14:19:42Z

Hm, then maybe we should add a heading, like for the bundles? I really think that we should keep the navigation lean and not list everything possible.

That really depends on how much apps you have installed/enabled. You never realize if you have a long list that you need to scroll down to find disabled apps there. A quick filter in the sidebar gives the user a hint that there is other stuff to look for.

jancborchardt · 2017-10-04T15:50:38Z

Ok, but for apps with an update I think it's still valid. There will likely never be so many apps at the same time with an update that you need to scroll.

But my feelings on this aren't soo strong that I feel arguing against you more, so ok. ;)

Signed-off-by: Julius Härtl <jus@bitgrid.net>

georgehrke · 2017-10-24T09:27:23Z

This pull-request doesn't seem to introduce an Update all button. Is there a dedicated pr or issue for that? :)

juliushaertl · 2017-10-24T09:43:33Z

This pull-request doesn't seem to introduce an Update all button. Is there a dedicated pr or issue for that? :)

Not that I'm aware of, but that is a neat idea.

jancborchardt · 2017-10-24T13:11:24Z

@georgehrke @juliushaertl mind opening a new isue for it? Or is anyone already working on a pull request? :)

juliushaertl added 2. developing Work in progress enhancement feature: apps management labels Oct 3, 2017

juliushaertl force-pushed the apps-management-updates branch 2 times, most recently from 39603fe to 9256c75 Compare October 3, 2017 13:31

juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2017

juliushaertl requested review from skjnldsv, nickvergessen and eppfel October 3, 2017 14:04

skjnldsv requested changes Oct 3, 2017

View reviewed changes

skjnldsv approved these changes Oct 3, 2017

View reviewed changes

skjnldsv requested changes Oct 3, 2017

View reviewed changes

nickvergessen reviewed Oct 4, 2017

View reviewed changes

juliushaertl force-pushed the apps-management-updates branch from c96e954 to afdc212 Compare October 4, 2017 12:24

nickvergessen approved these changes Oct 4, 2017

View reviewed changes

skjnldsv approved these changes Oct 4, 2017

View reviewed changes

juliushaertl force-pushed the apps-management-updates branch from afdc212 to 3706ed0 Compare October 8, 2017 21:44

juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 8, 2017

nickvergessen mentioned this pull request Oct 10, 2017

Automatic updates of apps as an option #3182

Closed

juliushaertl added 5 commits October 10, 2017 12:34

App management: add update section

8d1b32e

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Do not return app names multiple times

ec0091d

Signed-off-by: Julius Härtl <jus@bitgrid.net>

App management: do not reset update counter to 0 on category change

6f7fb2e

Signed-off-by: Julius Härtl <jus@bitgrid.net>

App management: Show proper message when no updates are available

a3502c5

Signed-off-by: Julius Härtl <jus@bitgrid.net>

App management: Do not show udpdate category if no updates are available

bee9ef8

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl force-pushed the apps-management-updates branch from 3706ed0 to bee9ef8 Compare October 10, 2017 10:34

juliushaertl merged commit 0def38b into master Oct 10, 2017

juliushaertl deleted the apps-management-updates branch October 10, 2017 12:57

hanzei mentioned this pull request Oct 19, 2017

Settings Apps Redesign Overview #3194

Closed

13 tasks

nickvergessen mentioned this pull request Oct 19, 2017

Show apps with updates at the top of the apps list #6871

Closed

MorrisJobke added this to the Nextcloud 13 milestone Oct 23, 2017

This was referenced Oct 28, 2017

Add an "Updates pending" category to the apps list categories (left pane links) #6985

Closed

Add update all button in the apps management #6989

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Updates section to app management #6739

Add Updates section to app management #6739

juliushaertl commented Oct 3, 2017 •

edited

Loading

codecov bot commented Oct 3, 2017 •

edited

Loading

skjnldsv left a comment •

edited

Loading

juliushaertl commented Oct 3, 2017

skjnldsv left a comment •

edited

Loading

juliushaertl commented Oct 3, 2017

skjnldsv commented Oct 3, 2017

juliushaertl commented Oct 3, 2017 •

edited

Loading

nickvergessen Oct 4, 2017

nickvergessen commented Oct 4, 2017

juliushaertl commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

skjnldsv commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

skjnldsv commented Oct 4, 2017

juliushaertl commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

georgehrke commented Oct 24, 2017

juliushaertl commented Oct 24, 2017

jancborchardt commented Oct 24, 2017

Add Updates section to app management #6739

Add Updates section to app management #6739

Conversation

juliushaertl commented Oct 3, 2017 • edited Loading

codecov bot commented Oct 3, 2017 • edited Loading

Codecov Report

skjnldsv left a comment • edited Loading

Choose a reason for hiding this comment

juliushaertl commented Oct 3, 2017

skjnldsv left a comment • edited Loading

Choose a reason for hiding this comment

juliushaertl commented Oct 3, 2017

skjnldsv commented Oct 3, 2017

juliushaertl commented Oct 3, 2017 • edited Loading

nickvergessen Oct 4, 2017

Choose a reason for hiding this comment

nickvergessen commented Oct 4, 2017

juliushaertl commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

skjnldsv commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

skjnldsv commented Oct 4, 2017

juliushaertl commented Oct 4, 2017

jancborchardt commented Oct 4, 2017

georgehrke commented Oct 24, 2017

juliushaertl commented Oct 24, 2017

jancborchardt commented Oct 24, 2017

juliushaertl commented Oct 3, 2017 •

edited

Loading

codecov bot commented Oct 3, 2017 •

edited

Loading

skjnldsv left a comment •

edited

Loading

skjnldsv left a comment •

edited

Loading

juliushaertl commented Oct 3, 2017 •

edited

Loading