Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app content list #7195

Merged
merged 6 commits into from
Nov 20, 2017
Merged

Add app content list #7195

merged 6 commits into from
Nov 20, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 16, 2017

Fix #6612

This implements the app content list standardisation across apps.
Updated test template: templatetest.tar.gz

kazam_screenshot_00008

@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 2. developing Work in progress design Design, UI, UX, etc. enhancement medium papercut Annoying recurring issue with possibly simple fix. labels Nov 16, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Nov 16, 2017
@skjnldsv skjnldsv self-assigned this Nov 16, 2017
@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #7195 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7195      +/-   ##
============================================
+ Coverage     50.79%   50.84%   +0.04%     
- Complexity    24488    24546      +58     
============================================
  Files          1582     1585       +3     
  Lines         93619    93797     +178     
  Branches       1354     1354              
============================================
+ Hits          47552    47688     +136     
- Misses        46067    46109      +42
Impacted Files Coverage Δ Complexity Δ
apps/dav/appinfo/app.php 28.57% <0%> (-11.43%) 0% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.94% <0%> (-1.81%) 74% <0%> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php 84.99% <0%> (-0.73%) 242% <0%> (+23%)
apps/dav/lib/AppInfo/Application.php 20.22% <0%> (-0.71%) 14% <0%> (+1%)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 83.19% <0%> (-0.16%) 126% <0%> (+1%)
apps/dav/composer/composer/autoload_classmap.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
apps/dav/composer/composer/autoload_static.php 0% <0%> (ø) 1% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/CalendarManager.php 78.57% <0%> (ø) 4% <0%> (?)
apps/dav/lib/CalDAV/CalendarImpl.php 96.66% <0%> (ø) 10% <0%> (?)
... and 5 more

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@jancborchardt
Copy link
Member

Awesome! Let’s review this @nextcloud/designers! :)

@skjnldsv this is still marked as »developing«, is that correct?

@jancborchardt jancborchardt removed the papercut Annoying recurring issue with possibly simple fix. label Nov 16, 2017
@skjnldsv
Copy link
Member Author

I'll finish it up tomorrow :)

@ChristophWurst
Copy link
Member

@skjnldsv @jancborchardt would be great to wait mentioning or assigning reviews until it's actually ready to be reviewed. Otherwise this results in notification spam with every single commit and comment. Thanks.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Sorry!! 🙈 😅

Updated test template: templatetest.tar.gz

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member

Added some fixes, it’s good to go now imo. What did you want to change @skjnldsv?
screenshot from 2017-11-20 14-13-16

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2017
@MorrisJobke MorrisJobke merged commit bca1658 into master Nov 20, 2017
@MorrisJobke MorrisJobke deleted the app-content-list branch November 20, 2017 13:41
@skjnldsv
Copy link
Member Author

Added some fixes, it’s good to go now imo. What did you want to change @skjnldsv?

@MorrisJobke MorrisJobke merged commit bca1658 into master 9 minutes ago

Ahaha, did not have time to check :D

@jancborchardt
Copy link
Member

Great work @skjnldsv! :) So do we now backport this to stable12, and at the same time add it to the Mail and Contacts apps too for backwards compatibility? Or just that, without backporting?

@skjnldsv
Copy link
Member Author

Thanks!

No! Backporting, makes no sense for new features stuff, unless it's a bug :)
Let's add a fix for mail and contacts (nextcloud/contacts/pull/438) like we did for the app navigation and we'll see from there ;)

@jancborchardt
Copy link
Member

Btw @daita this should be implemented by Circles as well so it fits with the overall Nextcloud design. :) Design guidelines for other components you can find at https://docs.nextcloud.com/server/12/developer_manual/design/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement medium standardisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants