[stable10] Add new apps as official #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @DeepDiver1975 and @rullzer to be potential reviewers |
|
👍 |
1 similar comment
|
👍 |
LukasReschke
force-pushed
the
stable10-add-new-apps-as-official
branch
from
080a2a2
to
66f6a91
Compare
| @@ -30,7 +30,13 @@ | |||
| "user_external", | |||
| "user_ldap", | |||
| "user_saml", | |||
| "workflowengine" | |||
| "workflowengine", | |||
| "user_saml", | |||
There was a problem hiding this comment.
Is this double? To lines above.
|
👎 |
|
Also files_* apps are already in the list |
|
Pushed to fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @schiessle @karlitschek @nickvergessen