Fix scss webroot and url rewrite #7631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
fix-scss-webroot-and-url-rewrite
branch
from
835f6fa
to
24a30fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #7631 +/- ##
============================================
+ Coverage 51.17% 51.18% +0.01%
- Complexity 24886 24889 +3
============================================
Files 1602 1602
Lines 94752 94798 +46
Branches 1368 1368
============================================
+ Hits 48486 48522 +36
- Misses 46266 46276 +10
|
skjnldsv
force-pushed
the
fix-scss-webroot-and-url-rewrite
branch
4 times, most recently
from
1d9da6c
to
5a9d097
Compare
skjnldsv
force-pushed
the
fix-scss-webroot-and-url-rewrite
branch
16 times, most recently
from
e5bb608
to
c732f56
Compare
skjnldsv
added
3. to review
|
Test finally fixed! :) @zauguin please test! 😃 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Fixed tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
- With root installation - Core css - App inside server root - Secondary apps directory outside server root - With an installation in a sub directory - Core css - App inside server root - Secondary apps directory outside server root Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-scss-webroot-and-url-rewrite
branch
from
c732f56
to
c0c4443
Compare
juliushaertl
approved these changes
Jan 2, 2018
|
Works fine. Awesome👍 |
|
We need a backport imho :) |
|
@skjnldsv Do it ;) |
|
Backport is fine. Please note that this change has the potential to break in esoteric/non standard webserver setups. So good testing is important. |
|
@karlitschek that's why I added tests with various installation instances to make sure it doesn't break. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7534
Also fixes the following situations:
➡️ Fix the massiv log spamming of not finding the webroot
TODO: