Don't encode paths that will be passed to the davclient #7765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This is handled already in the client. So double encoding breaks things in some situations. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
nickvergessen,
MorrisJobke,
ChristophWurst,
enoch85 and
danxuliu
Codecov Report
@@ Coverage Diff @@
## master #7765 +/- ##
============================================
- Coverage 51.22% 51.22% -0.01%
Complexity 24967 24967
============================================
Files 1607 1607
Lines 94989 94990 +1
Branches 1376 1376
============================================
Hits 48662 48662
- Misses 46327 46328 +1
|
|
This replaces #4528 ?! |
Seems so - I also had something like this in mind, but the solution here looks better AFAIK. |
|
Yup it works. Thanks! 👍 |
enoch85
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574
Those paths will be encoded by the davclient again. So in certain situations this leads to double encoded urls. Which can fail.
To test:
Before: 💥
Now: 🕺