New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Better result handling of email search #8205

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Feb 6, 2018

The limit of the response should be respected

Fix nextcloud/spreed#617

Master/stable13 needs a different patch (collaboration rewrite) but will come soon.

@nickvergessen nickvergessen added this to the Nextcloud 12.0.6 milestone Feb 6, 2018

@nickvergessen nickvergessen changed the title from Better result handling of email search to [stable12] Better result handling of email search Feb 6, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 6, 2018

Codecov Report

Merging #8205 into stable12 will decrease coverage by 0.03%.
The diff coverage is 25%.

@@              Coverage Diff               @@
##             stable12    #8205      +/-   ##
==============================================
- Coverage       53.84%   53.81%   -0.04%     
- Complexity      22755    22758       +3     
==============================================
  Files            1386     1386              
  Lines           87129    87180      +51     
  Branches         1331     1331              
==============================================
- Hits            46914    46913       -1     
- Misses          40215    40267      +52
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/ShareesAPIController.php 56.59% <25%> (-6.65%) 121 <0> (+3)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
@rullzer

rullzer approved these changes Feb 8, 2018

Limit the number of results when searching for remotes and emails
Signed-off-by: Joas Schilling <coding@schilljs.com>

@MorrisJobke MorrisJobke merged commit 0b21cab into stable12 Feb 21, 2018

1 of 3 checks passed

codecov/patch 50% of diff hit (target 53.84%)
Details
codecov/project 53.84% (-0.01%) compared to 363b1da
Details
continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the bugfix/noid/fix-result-size-when-searching-for-sharees branch Feb 21, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

12.0.6 RC 1 #8750

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment