Fixed files copy/move when in favorites or recent section #8945
Conversation
| } | ||
| if (type === OC.dialogs.FILEPICKER_TYPE_MOVE) { | ||
| context.fileList.move(filename, targetPath); | ||
| context.fileList.move(filename, targetPath, false, context.dir); |
There was a problem hiding this comment.
move() doesn't have a 4th parameter
There was a problem hiding this comment.
@skjnldsv The first time MoveCopy successfully . Error still occurs when the file is moved or copied a second time
There was a problem hiding this comment.
@HandsomeBoby a second time after reload? In the same location?
There was a problem hiding this comment.
@skjnldsv Not understand what you mean. I mean, in the Recent, choose a file for MoveCopy is successfully, reloading, there was an error while making a second MoveCopy to this file.
such as:
this is successfully! reloading
There was an error.
There was a problem hiding this comment.
Nope, can't reproduce with the last patch, it works great! :)
Let's get this in!
There was a problem hiding this comment.
@skjnldsv
Sorry,My English is a bit bad.
On the recent page,move a file in the folder to the “/”, an error occurred while moving this file again. Not need to reload.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-files-copy-in-recent-favorites
branch
from
5c24e1b
to
24ecf3f
Compare
Codecov Report
@@ Coverage Diff @@
## master #8945 +/- ##
============================================
+ Coverage 51.88% 51.96% +0.07%
+ Complexity 25270 25269 -1
============================================
Files 1603 1603
Lines 94878 94878
Branches 1388 1388
============================================
+ Hits 49228 49301 +73
+ Misses 45650 45577 -73
|
skjnldsv
added
2. developing
|
Failure unrelated (swift) and checker pass on restart! :) |
|
@skjnldsv What about the backport? |
Ping ;) |
|
Backported in #9238 |
Fix #8851