Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default log rotate size to 100 MB #9137

Merged
merged 1 commit into from Apr 11, 2018

Conversation

MorrisJobke
Copy link
Member

No description provided.

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #9137 into master will decrease coverage by 20.35%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #9137       +/-   ##
=============================================
- Coverage     51.84%   31.48%   -20.36%     
  Complexity    25313    25313               
=============================================
  Files          1604     1604               
  Lines         95133    95133               
  Branches       1387     1387               
=============================================
- Hits          49324    29957    -19367     
- Misses        45809    65176    +19367
Impacted Files Coverage Δ Complexity Δ
lib/private/Log/Rotate.php 0% <0%> (ø) 4 <0> (ø) ⬇️
config/config.sample.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/DB/OCSqlitePlatform.php 0% <0%> (-100%) 5% <0%> (ø)
apps/files_versions/lib/AppInfo/Application.php 0% <0%> (-100%) 2% <0%> (ø)
apps/user_ldap/lib/LDAPProviderFactory.php 0% <0%> (-100%) 2% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
lib/public/Files/ForbiddenException.php 0% <0%> (-100%) 2% <0%> (ø)
lib/public/Comments/CommentsEvent.php 0% <0%> (-100%) 3% <0%> (ø)
...ib/private/Files/Config/UserMountCacheListener.php 0% <0%> (-100%) 2% <0%> (ø)
apps/user_ldap/lib/Settings/Admin.php 0% <0%> (-100%) 5% <0%> (ø)
... and 368 more

@MorrisJobke
Copy link
Member Author

👍 for the changes of @rullzer

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

Fixed the tests.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 10, 2018
@MorrisJobke MorrisJobke merged commit e302266 into master Apr 11, 2018
@MorrisJobke MorrisJobke deleted the default-log-rotate-size branch April 11, 2018 00:10
@WNYmathGuy
Copy link

This wasn't implemented yet, was it? My current nextcloud.log is 147.90 MB and growing. I thing a 50 MB log is too big. My current one has got entries from the birthday of my server on February 25th. I had a fudged up the temp folder situation and log entries were going in maybe faster than 4 per second for a long time where I didn't know about it.

@blizzz
Copy link
Member

blizzz commented Jun 4, 2018

@WNYmathGuy it's implemented for upcoming Nc 14:

screenshot_20180604_094537

@ghost
Copy link

ghost commented Aug 12, 2018

Is there a setting for how many rotations that should be kept?

@blizzz
Copy link
Member

blizzz commented Aug 13, 2018

Please ask questions like this in help.nextcloud.com, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants