Add cachebusters #934
Merged
Add cachebusters #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @MorrisJobke to be potential reviewers |
| @@ -860,7 +860,7 @@ span.ui-icon {float: left; margin: 3px 7px 30px 0;} | |||
| div.crumb { | |||
| float: left; | |||
| display: block; | |||
| background-image: url('../img/breadcrumb.svg'); | |||
| background-image: url('../img/breadcrumb.svg?v=1'); | |||
|
👍 |
|
damn that is ugly.... 🙊 |
|
To be increased every release? |
If the linked resource changes, we have this already in place for a few other CSS files. But those were missing. |
|
|
|
@nextcloud/designers @Bugsbane Just to let you know of this: When changing an image/icon/... check if there is a reference right inside the CSS and adjust the number. This then allows us to provide the cache buster to hit in and always the correct image is used ;) |
|
Alright, sounds good! :) |
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Add cachebusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81