Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the master unit tests #9711

Merged
merged 1 commit into from Jun 1, 2018
Merged

Fix the master unit tests #9711

merged 1 commit into from Jun 1, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jun 1, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Fix the master unit tests
3ca1525 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Jun 1, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Jun 1, 2018
MorrisJobke
MorrisJobke approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@codecov
Copy link

codecov bot commented Jun 1, 2018 •
edited

Codecov Report

Merging #9711 into master will increase coverage by 20.27%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #9711       +/-   ##
=============================================
+ Coverage     31.44%   51.72%   +20.27%     
  Complexity    25729    25729               
=============================================
  Files          1635     1635               
  Lines         96017    96017               
  Branches       1384     1384               
=============================================
+ Hits          30190    49661    +19471     
+ Misses        65827    46356    -19471
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Stream/Encryption.php 75.22% <0%> (+0.45%) 54% <0%> (ø) ⬇️
apps/theming/lib/ThemingDefaults.php 90% <0%> (+0.62%) 56% <0%> (ø) ⬇️
lib/private/Setup.php 12.55% <0%> (+0.83%) 52% <0%> (ø) ⬇️
lib/public/AppFramework/Db/Mapper.php 94.95% <0%> (+0.84%) 30% <0%> (ø) ⬇️
lib/private/Group/Group.php 82.75% <0%> (+0.86%) 56% <0%> (ø) ⬇️
...vate/Authentication/Token/DefaultTokenProvider.php 98.03% <0%> (+0.98%) 32% <0%> (ø) ⬇️
lib/private/Preview/Generator.php 78.28% <0%> (+1.14%) 53% <0%> (ø) ⬇️
lib/private/App/DependencyAnalyzer.php 95.62% <0%> (+1.25%) 64% <0%> (ø) ⬇️
lib/private/Settings/Manager.php 64.33% <0%> (+1.39%) 42% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️
... and 377 more

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 1, 2018
@MorrisJobke MorrisJobke merged commit 38c38ee into master Jun 1, 2018
@MorrisJobke MorrisJobke deleted the fix/noid/fixmaster_unittests branch June 1, 2018 12:10
@MorrisJobke
Copy link
Member

Ref #9550

@MorrisJobke
Copy link
Member

Let's backport this to stable13 as well

@MorrisJobke MorrisJobke mentioned this pull request Jun 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rullzer @MorrisJobke @blizzz