Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 7 and 30 day values to "Active Users" stats graph #267

Closed

Conversation

akhil1508
Copy link

@akhil1508 akhil1508 commented Jan 11, 2021

  • Added 7 and 30 day values to the "Active users" stats graph (returned through "lib/SessionStatistics.php" and used in frontend in "js/script.js)
  • Modified unit tests accordingly to test that new values are correctly returned
  • Package "nextcloud/coding-standard" updated to "^0.4.0" from "^0.3.0"(PHPLint refuses to install correctly with 0.3.0 in the checks otherwise)

ConstrictM and others added 26 commits January 12, 2021 14:07
Signed-off-by: Matthew Wener <mwener115@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Matthew Wener <mwener115@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Matthew Wener <mwener115@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
Signed-off-by: akhil <akhil.potukuchi@gmail.com>
@akhil1508 akhil1508 changed the title Frontend and test fixes Added 7 and 30 day values to "Active Users" stats graph Jan 18, 2021
@arnauvp
Copy link

arnauvp commented Jan 29, 2021

Ping

@J0WI
Copy link
Contributor

J0WI commented Feb 17, 2021

The performance is already pretty bad on large instances. Most likely due share statistics but better safe than sorry.

@arnauvp
Copy link

arnauvp commented Feb 19, 2021

On our instance, the serverinfo/api/v1/info?format=json call takes up to 5.5 seconds. The DB query to fetch unique users in last 30 days takes ~400ms before it's cached.

@nickvergessen
Copy link
Member

Needs a major overhaul after #420

Want to have a look?

@nickvergessen nickvergessen removed this from the Nextcloud 26 milestone Jan 25, 2023
@akhil1508 akhil1508 closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants