Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard accessibility for emoji picker and profile tabs #103

Merged
merged 3 commits into from Dec 3, 2018

Conversation

juliushaertl
Copy link
Member

Fixes #96

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Dec 3, 2018
@jancborchardt jancborchardt added this to the 0.1 🥚 milestone Dec 3, 2018
@jancborchardt
Copy link
Member

Awesome, thank you! :) Only one thing: Is it possible that after pressing enter on the emoji picker toggle, the input field is automatically focused so you can start typing?

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

@jancborchardt Fixed as well.

@jancborchardt
Copy link
Member

And sorry – two other things with the flow:

  • When you type in the search field and then press enter, the first emoji should automatically be inserted. (Currently you need to tab and then press enter.)
  • After inserting an emoji like this, the picker should automatically be closed with a space inserted after it so you can continue typing.

Is that possible? This will be very useful for everyone using the emoji picker. :)

@juliushaertl
Copy link
Member Author

@jancborchardt I'd just look into this two issues in a separate PR, since they will require a bit more work.

@juliushaertl juliushaertl merged commit c45cfe6 into master Dec 3, 2018
@juliushaertl juliushaertl deleted the bugfix/96/accessibility branch December 3, 2018 15:14
juliushaertl added a commit that referenced this pull request Dec 3, 2018
Keyboard accessibility for emoji picker and profile tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants