Revert removal of MessageContent #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1561 Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
added
bug
|
Will have a look, but haven't been able to test the previous version as this didn't run on NC25 |
ArtificialOwl
approved these changes
Jan 12, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
Can't reproduce cypress issue locally, and it is not due to this PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoration of
MessageContentas it seems to correctly render different kind of notes.@gbraad This should fix #1561. I am wondering when did this issue started to occur, and whether it used to work. Can you tell me if you also have this issue in
v0.4.2@CarlSchwan any chances you could pop in and explain why you removed it in the first place ?