Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(RoomSelector): reduce bundle size, fix redirecting from sidebar #11609

Merged
merged 3 commits into from Feb 23, 2024
Merged

[stable27] fix(RoomSelector): reduce bundle size, fix redirecting from sidebar #11609

merged 3 commits into from Feb 23, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 20, 2024 •
edited by Antreesy

Partial Backport of #11606
Backport of #11616

Warning, This backport's changes differ from the original and might be incomplete ⚠️

@backportbot backportbot bot added this to the 💛 Next Patch (27) milestone Feb 20, 2024
@Antreesy Antreesy changed the title [stable27] [stable28] chore(RoomSelector): reduce bundle size [stable27] chore(RoomSelector): reduce bundle size Feb 20, 2024
@Antreesy Antreesy marked this pull request as ready for review February 20, 2024 14:52
@Antreesy
Copy link
Contributor

Antreesy commented Feb 20, 2024 •
edited

cc @DorraJaouad

@Antreesy Antreesy self-assigned this Feb 20, 2024
@Antreesy
Copy link
Contributor

/backport! to stable26

@backportbot backportbot bot mentioned this pull request Feb 20, 2024
Merged
@Antreesy
chore(RoomSelector): provide whole conversation object
d22ebbb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
chore(RoomSelector): dynamic import component in plugins to reduce bu…
bd05892 
…ndle size

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
DorraJaouad
DorraJaouad approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Deck fix worked.

@Antreesy
fix(Forwarder): use native browser navigation outside of Talk
63ce76c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy changed the title [stable27] chore(RoomSelector): reduce bundle size [stable27] fix(RoomSelector): reduce bundle size, fix redirecting from sidebar Feb 22, 2024
@nickvergessen
Copy link
Member

CI was fixed in parallel, so executing your 2 approvals

@nickvergessen nickvergessen merged commit 46ca26a into stable27 Feb 23, 2024
34 checks passed
@nickvergessen nickvergessen deleted the backport/11606/stable27 branch February 23, 2024 14:58
This was referenced Feb 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
v17.1.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Antreesy @nickvergessen @DorraJaouad