Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(RoomSelector): reduce bundle size, fix redirecting from sidebar #11606

Merged
merged 4 commits into from Feb 22, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 20, 2024

Partial backport of #11589
Backport of #11616

Warning, This backport's changes differ from the original and might be incomplete ⚠️

@backportbot backportbot bot added this to the 💚 Next Patch (28) milestone Feb 20, 2024
@Antreesy Antreesy force-pushed the backport/11589/stable28 branch 2 times, most recently from 3b341e7 to dc353de Compare February 20, 2024 13:38
@Antreesy Antreesy marked this pull request as ready for review February 20, 2024 13:39
@Antreesy
Copy link
Contributor

Didn't backport RoomSelector refactoring changes and isPlugin prop, only dynamic import + issue fixes
cc @DorraJaouad give it a try please

@Antreesy
Copy link
Contributor

/backport! to stable27

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Nothing seems to be missed.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…ndle size

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 5ea9006)
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Files, Video verification and Talk.

@Antreesy Antreesy changed the title [stable28] chore(RoomSelector): reduce bundle size [stable28] fix(RoomSelector): reduce bundle size, fix redirecting from sidebar Feb 22, 2024
@Antreesy Antreesy merged commit c86d62b into stable28 Feb 22, 2024
44 checks passed
@Antreesy Antreesy deleted the backport/11589/stable28 branch February 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants