Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The password request notification may not be received by the sharer #1260

Closed
danxuliu opened this issue Oct 16, 2018 · 0 comments
Closed

The password request notification may not be received by the sharer #1260

danxuliu opened this issue Oct 16, 2018 · 0 comments
Assignees
Labels

Comments

@danxuliu
Copy link
Member

When a share:password room is created a notification is sent to the sharer to inform her that the e-mail receiver requested the password to access a share. However, as a new call is immediately started when the password is requested (once the media permissions are granted or rejected) the previous notifications for that room are removed, so the sharer may only receive the call notification instead of the password request one. In this specific case, in my opinion, it would make more sense not to send the call notification and to send only the password request notification.

Even if the call notification is still sent but ensuring that it does not remove the password request notification currently the room name is simply set to the e-mail address to compose the name as Password request by user@server.com when formatting it in the RoomController. However, when the room name is used in the call notification it becomes A group call has started in user@server.com, which is strange.

All this happens both in stable14 and in current master branches.

@nickvergessen Could you take care of that? Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants