Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ File caption #5354

Closed
2 of 4 tasks
jakobroehrl opened this issue Mar 9, 2021 · 4 comments · Fixed by #10053
Closed
2 of 4 tasks

🏷️ File caption #5354

jakobroehrl opened this issue Mar 9, 2021 · 4 comments · Fixed by #10053
Labels

Comments

@jakobroehrl
Copy link
Contributor

jakobroehrl commented Mar 9, 2021

Wouldn't it be nice if we had the possibility to add a caption to the file upload?
This time the user posts the file share in the first message and sometimes a second message with a description.


@jakobroehrl jakobroehrl changed the title attachment caption file share caption Mar 9, 2021
@nickvergessen nickvergessen added 1. to develop feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings and removed 0. Needs triage labels Mar 24, 2021
@nickvergessen
Copy link
Member

So the big issue is that we share the file via the sharing api and we don't have a way there to post a related message.
We might be able to use the share note or something, but that is limited to 1k chars, does not support mentions or anything and so on. So not too sure about it yet.

@nickvergessen
Copy link
Member

An idea that crossed my mind yesterday:
In the meantime we have the talkMetaData parameter on shares, e.g. to make clear that a shared file is a voice message.
Maybe we could do that too with the "caption"?

@Antreesy
Copy link
Contributor

Antreesy commented Mar 3, 2023

Proposal for message and upload modal appearance (see screenshots and mockups below):

Message appearance in chat Upload files modal appearance
image image

@nickvergessen
Copy link
Member

As per discussion the plan is the following:

  1. We add a defined magic parameter to the share endpoint that will make talk not create the share system message
  2. A dedicated other endpoint will then be added where the text message + share id(s) is sent to and that will create the caption-message and serve the attachment(s) in the message parameter list, so that clients themselves can decide how to render them.

Another problem might be if we allow multiple items, and not each of them has a system message, the shared item tabs does not have an entry for each of them.
We might need to extend the database + API of shared items, to be able to create multiple entries for the same message id.

(that will also be helpful in the future when implementing shared items sections for URLs as there can also be more than 1 per message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants