Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add a caption when sharing media or file through iOS share sheet #779

Closed
e-caste opened this issue May 3, 2022 · 7 comments

Comments

@e-caste
Copy link
Contributor

e-caste commented May 3, 2022

Is your feature request related to a problem? Please describe.
At the moment if we want to, for example, send an image to a Nextcloud Talk chat with a caption we have to:

  1. choose the image
  2. open the share sheet
  3. choose Nextcloud Talk
  4. choose the chat
  5. send the image
  6. open Nextcloud Talk
  7. choose the same chat
  8. send the caption separately

Describe the solution you'd like
It would be nice if we could add a caption directly to the image (or file) right before sharing it:

What iOS Messages does What Nextcloud Talk could do ("Add a comment..." text field shamelessly stolen by Telegram share sheet)
IMG_0D9DB9533084-1 IMG_A7E2D717B9ED-1

This would result in the following steps:

  1. choose the image
  2. open the share sheet
  3. choose Nextcloud Talk
  4. choose the chat
  5. add a comment
  6. send the image

which would eliminate the hassle of having to manually open the app again just to add a comment to the shared media.

The comment can be sent in a separate message following the media file, since I don't think Nextcloud currently supports captions.

Describe alternatives you've considered
Not relevant.

Additional context
Using Nextcloud Talk iOS 14.0.0.

@SystemKeeper
Copy link
Collaborator

Hi @e-caste
Thank you for your ideas! I remember discussing this in the past and the problem was/is that media and text can’t be combined in a single message, so it would be 2 messages. But it would be possible, basically.
Any opinions @Ivansss ? Should we add a text field and send 2 messages?

@e-caste
Copy link
Contributor Author

e-caste commented May 4, 2022

@SystemKeeper Yes, that was my idea as well:

The comment can be sent in a separate message following the media file, since I don't think Nextcloud currently supports captions.

@Ivansss
Copy link
Member

Ivansss commented May 4, 2022

Interesting idea indeed :) As @SystemKeeper this is currently not possible due to the current API but sending a second message could be a workaround for implementing this feature.

@nickvergessen
Copy link
Member

Server ref:
nextcloud/spreed#5354

But we also have "metaData" already for shares, e.g. to mark voice messages different. Could also add a comment field on that.
However if we simply duck-tape that together into

{file}
"Inserted comment"

It would break the rendering currently done by the clients, so that would need a bit coordination

@SystemKeeper
Copy link
Collaborator

Should we implement this as two messages as a first step? We could chain the sending, first upload and post the file, then post a message directly after.
Changes to the gui would be the same as having server support for this, so needs to be done either way.

@nickvergessen
Copy link
Member

I think we should wait and then bring and support this properly on all platforms in one cycle.

@SystemKeeper
Copy link
Collaborator

Fixed by #1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants