Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show groups in dropdown, and omit yourself #67

Closed
jancborchardt opened this issue Oct 19, 2016 · 3 comments
Closed

Show groups in dropdown, and omit yourself #67

jancborchardt opened this issue Oct 19, 2016 · 3 comments
Milestone

Comments

@jancborchardt
Copy link
Member

In the »Choose person« dropdown we should also show the groups you are part of, and omit yourself.

@jancborchardt jancborchardt added this to the 1.0.0 milestone Oct 19, 2016
@nickvergessen
Copy link
Member

@schiessle @rullzer I wonder if https://github.com/nextcloud/server/blob/6e52091c8e344cf0ea83ab44f79c550f139bb6ac/apps/files_sharing/lib/Controller/ShareesAPIController.php#L434-L436 should be registered also based on the itemType, so e.g. this spreed app can return users independent from the share manager.

I like the idea of having one endpoint for all these requests, but on the other hand it already starts getting messy a bit. Any though?

@rullzer
Copy link
Member

rullzer commented Nov 10, 2016

mmmm I get your point @nickvergessen. Having yet another endpoint would hugely duplicate the code.

Possibility would be to filter based on the itemType indeed.

However, keep in mind that we search based share type. So the sharees have to properly fall into that category.

@nickvergessen
Copy link
Member

Server was merged, groups are displayed and the current user is skipped => closing

marcoambrosini pushed a commit that referenced this issue Oct 9, 2019
Fix a webpack devtool that works without unsave-eval CSP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants