Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit the default sort order by as 'ASC' #9077

Closed
vitormattos opened this issue Mar 17, 2023 · 1 comment
Closed

Explicit the default sort order by as 'ASC' #9077

vitormattos opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Milestone

Comments

@vitormattos
Copy link
Contributor

vitormattos commented Mar 17, 2023

Replace the all output of follow command that haven't the default value 'ASC' to use the default:

grep -R -P "orderBy\('[\w\.]+'\)" lib/

lib/Signaling/Messages.php:			->orderBy('id');
lib/Share/RoomShareProvider.php:		$qb->orderBy('s.id');
lib/Share/RoomShareProvider.php:		$qb->orderBy('id');
lib/Share/RoomShareProvider.php:				->orderBy('s.id')
lib/Share/RoomShareProvider.php:			->orderBy('id');
lib/Manager.php:			->orderBy('r.id');

If is ->orderBy('id') should be ->orderBy('id', 'ASC')

Originally posted by @nickvergessen in #9075 (comment)

@vitormattos vitormattos changed the title Explicit is better :) Explicit the default sort order by as 'AND' Mar 17, 2023
@vitormattos vitormattos added good first issue feature: api 🛠️ OCS API for conversations, chats and participants labels Mar 17, 2023
@vitormattos vitormattos added this to the 🖤 Next Major (27) milestone Mar 17, 2023
@vitormattos vitormattos changed the title Explicit the default sort order by as 'AND' Explicit the default sort order by as 'ASC' Mar 17, 2023
vitormattos added a commit that referenced this issue Mar 17, 2023
#9077

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos self-assigned this Mar 17, 2023
@nickvergessen
Copy link
Member

Fixed by #9078 and #9075

backportbot-nextcloud bot pushed a commit that referenced this issue Mar 21, 2023
#9077

Signed-off-by: Vitor Mattos <vitor@php.rio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Projects
None yet
Development

No branches or pull requests

2 participants