Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messagesStore) - clean conversation history for participants in call #10299

Merged
merged 1 commit into from Aug 22, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

Solution might be a bit overkill, so here are some explanations:

  • System message history_cleared will be the first one in conversation by definition, so only previous messages should be cleared
  • Depending on internet connection, or after conversation switching - there could be a new messages after clearing, so we can't purge the whole room, because it also could clear new ones.
  • When scroll to the top and fetch - system message will be last processed and first known, so no mutations should occur

🖼️ Screenshots

clear-history.webm

🚧 Tasks

  • Code review

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@nickvergessen
Copy link
Member

/backport to stable27

@nickvergessen
Copy link
Member

/backport to stable26

@nickvergessen
Copy link
Member

/backport to stable25

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete chat messages - still visible to 3rd party despite cleared the history.. indicator
3 participants