Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store self as unique user in combined system message #10406

Merged
merged 1 commit into from
Aug 31, 2023
Merged

store self as unique user in combined system message #10406

merged 1 commit into from
Aug 31, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix broken system message, when for some reason user joined or left call several times in a row

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2023-08-29 13-55-07 Screenshot from 2023-08-29 13-54-26

🚧 Tasks

  • Code review
  • Manual check

🏁 Checklist

@Antreesy
store self as unique user in combined system message
9908120 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug regression feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Aug 29, 2023
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Aug 29, 2023
@Antreesy Antreesy self-assigned this Aug 29, 2023
@Antreesy
Copy link
Contributor Author

/backport to stable27

DorraJaouad
DorraJaouad approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit 35493d6 into master Aug 31, 2023
22 checks passed
@Antreesy Antreesy deleted the fix/noid/hide-duplicate-join-call branch August 31, 2023 16:14
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
bug feature: call 📹 Voice and video calls feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Antreesy @DorraJaouad