Start with system chat messages

[nickvergessen]

Fix #614

Messages

• Join/leave a call
• Last one leaves: call summary similar to activity
• Add/remove a user
• (Dis-)Allow guests
• Password changes/set/unset
• Promotion/demotion to moderator
• Room created
• Room renamed

Special design:

• message is 0.5 opacity like date/name on others
• mentions are not bold and not coloured
• no avatar and user name on those rows

[nickvergessen]

Ready for review @Ivansss

@danxuliu can you help with the layout when the chat is in the sidebar? The timestamp seems to overlap the message there, due to the missing author row parts.

@jancborchardt if you want to comment on the look, do it soon, please, not 2 days before the release ;)

[danxuliu]

@nickvergessen I have fixed the date on system messages. The fix itself is the first commit; the second commit provides a nicer layout (at least, in my opinion), but I added it in a separate commit easily droppable just in case I am the only one that likes it ;-)

Original:

Date on its own row (well, in this screenshot the text of the date when there is an author is not right-aligned, but it is fixed in the pushed commit):

Date and system messages merged:

[danxuliu]

Shouldn't it be Duration {duration} instead?

[nickvergessen]

No, similar to the room name on rename its not a placeholder (not a known rich object string type)

[fancycode]

The system chat messages should trigger an event to the standalone signaling server, so the clients get notified that they should load the new messages (similar to the regular chat messages).

With #1074 the ChatManager now has a dispatcher that could be used for this.

[nickvergessen]

@fancycode after adding the event+listener to update the chat, the signaling backend tests fail because the message is different:

1) OCA\Spreed\Tests\php\Signaling\BackendNotifierTest::testRoomInvite
Failed asserting that Array &0 (
    'type' => 'message'
    'message' => Array &1 (
        'data' => Array &2 (
            'type' => 'chat'
            'chat' => Array &3 (
                'refresh' => true
            )
        )
    )
) is identical to Array &0 (
    'type' => 'invite'
    'invite' => Array &1 (
        'userids' => Array &2 (
            0 => 'testUser'
        )
        'alluserids' => Array &3 (
            0 => 'testUser'
        )
        'properties' => Array &4 (
            'name' => ''
            'type' => 3
        )
    )
).

Can you help with that?

[fancycode]

Can you help with that?

The tests only remember the last message that was received:

spreed/tests/php/Signaling/BackendNotifierTest.php

Line 51 in bd78851

$this->lastRequest = [

With the system messages there will be more now: first the invite that would be checked by the test, then the refresh triggered by the system chat. You could either filter the chat messages in the test, or keep a list of messages and check if the expected message is in the list.

[fancycode]

Please rename to clearRequests to match the other function names.