Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix missing headlines after vue library changed from title t… #11030

Merged
merged 1 commit into from Nov 29, 2023
Merged

fix(UI): Fix missing headlines after vue library changed from title t… #11030

merged 1 commit into from Nov 29, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 29, 2023 •
edited

…o name

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Before After
Bildschirmfoto vom 2023-11-29 10-58-07 Bildschirmfoto vom 2023-11-29 10-58-44
Bildschirmfoto vom 2023-11-29 10-58-16 Bildschirmfoto vom 2023-11-29 10-58-35
Bildschirmfoto vom 2023-11-29 11-04-29 Bildschirmfoto vom 2023-11-29 11-06-13

🏁 Checklist

@nickvergessen
fix(UI): Fix missing headlines after vue library changed from title t…
e579959 
…o name

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Nov 29, 2023
ChristophWurst
ChristophWurst approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic

@nickvergessen nickvergessen merged commit 41240e6 into main Nov 29, 2023
35 checks passed
@nickvergessen nickvergessen deleted the bugfix/11029/fix-missing-titles branch November 29, 2023 10:21
@ChristophWurst
Copy link
Member

backport?

@nickvergessen
Copy link
Member Author

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

"Silent call" title missing
3 participants
@nickvergessen @ChristophWurst @Antreesy