Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(activeSession): minor fixes #11119

Merged
merged 1 commit into from Dec 5, 2023
Merged

fix(activeSession): minor fixes #11119

merged 1 commit into from Dec 5, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 5, 2023

☑️ Resolves

🖌️ UI Checklist

🚧 Tasks

  • To test:
    • 0. Set INACTIVE_TIME_MS to a lesser value (or wait 3 minutes)
    • 1. Join call
    • 1. Unfocus window (switch to another, or start screenshare)
    • 1. Wait for interval - session should be still active
    • 2. Unfocus window
    • 2. Focus back (within interval, so session still active)
    • 2. Wait for interval - session should be still active

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy
fix(activeSession): minor fixes
7ebd24a 
- always reset timer on window focus change
- do not set inactive state when in call

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 5, 2023
@Antreesy Antreesy self-assigned this Dec 5, 2023
SystemKeeper
SystemKeeper approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Ah, missed the test steps, sorry, let me try again. Worked for me

@nickvergessen
Copy link
Member

/backport to stable28

@Antreesy Antreesy merged commit 990ae05 into main Dec 5, 2023
36 checks passed
@Antreesy Antreesy deleted the fix/10887/session-in-call branch December 5, 2023 10:42
@DorraJaouad
Copy link
Contributor

  • Unfocus window but keep it shown ( in screen 1) and focus on another tab ( or screen 2)
  • Move mouse or scroll chat but without focusing on window ( like reading chat from open conversation)
    ==> session is marked as inactive

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Session is marked as inactive while participating in a call and even when sharing the own screen
4 participants
@Antreesy @nickvergessen @DorraJaouad @SystemKeeper