Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file share with caption quote reply #11120

Merged
merged 2 commits into from Dec 5, 2023
Merged

Fix file share with caption quote reply #11120

merged 2 commits into from Dec 5, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 5, 2023 •
edited

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 5, 2023
@DorraJaouad DorraJaouad added this to the 💙 Final RC (28) milestone Dec 5, 2023
@DorraJaouad DorraJaouad self-assigned this Dec 5, 2023
@nickvergessen
Copy link
Member

/backport to stable28

Antreesy
Antreesy reviewed Dec 5, 2023
View reviewed changes
src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, nicely done. Left some nitpicks:

src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
src/components/Quote.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix(Quote): Add file preview in reply with its shortened caption
7d1134e 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/11108/improve-file-share-quote-reply branch from 5e60d4e to 494262d Compare December 5, 2023 10:50
@DorraJaouad
fix(NewMessage): store caption without html escaping
29e1e81 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/11108/improve-file-share-quote-reply branch from 494262d to 29e1e81 Compare December 5, 2023 11:04
Antreesy
Antreesy approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again

@DorraJaouad DorraJaouad merged commit 4f2025b into main Dec 5, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/11108/improve-file-share-quote-reply branch December 5, 2023 12:19
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2023
Merged
@DorraJaouad DorraJaouad mentioned this pull request Dec 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Quotes of files with caption are too big
3 participants
@DorraJaouad @nickvergessen @Antreesy