Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix: use body element if not the fullscreen #11260

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[stable27] fix: use body element if not the fullscreen #11260

merged 4 commits into from
Dec 19, 2023

Conversation

DorraJaouad
Copy link
Contributor

Backport of #11222

@Antreesy @DorraJaouad
fix: use body element as modal container if not in fullscreen
5c94157 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy @DorraJaouad
fix: don't toggle fullscreen with hotkey when modal is open
04202de 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy @DorraJaouad
fix: re-mount NewMessage when toggle Fullscreen
00f9350 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@DorraJaouad DorraJaouad added bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Dec 18, 2023
@DorraJaouad DorraJaouad added this to the 💚 Next Patch (27) milestone Dec 18, 2023
DorraJaouad
DorraJaouad commented Dec 18, 2023
View reviewed changes
Copy link
Contributor Author

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Talk-sidebar in Files main app modals.

@nickvergessen
Fix eslint warnings
93497d9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 92fc5f6 into stable27 Dec 19, 2023
33 checks passed
@nickvergessen nickvergessen deleted the backport/11222/stable27 branch December 19, 2023 05:40
This was referenced Dec 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v17.1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DorraJaouad @nickvergessen @Antreesy