Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(NewMessage): Clear main message input when upload editor is open #11838

Merged
merged 1 commit into from Mar 18, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 17, 2024

☑️ Resolves

Main chat input stays empty when upload editor is open.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💞 Next Beta (29) milestone Mar 17, 2024
@DorraJaouad DorraJaouad self-assigned this Mar 17, 2024
@nickvergessen
Copy link
Member

Random thought, instead of clearing it, could we "hide" it? :P

@Antreesy
Copy link
Contributor

instead of clearing it, could we "hide" it? :P

Opacity applies only partly (wouldn't work here for text nodes), and some guards from the PR are nice to have to prevent some side computations

@DorraJaouad
Copy link
Contributor Author

Random thought, instead of clearing it, could we "hide" it? :P

It will use some invisible computations that we don't need.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@Antreesy Antreesy merged commit 3693520 into main Mar 18, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/chat-input branch March 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants