Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conversation): allow to invite federated user when creating a conversation #11862

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix(conversation): allow to invite federated user when creating a conversation #11862

merged 1 commit into from Mar 19, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • allow to invite federated user when creating a conversation
  • conversation creation flow seems to work without errors (with stable network)

🖼️ Screenshots / Screencasts

Avatar is only shown, if user is joined to the room, which can proxy this exact avatar from remote server
image

  • LeftSidebar search also returns federated user as an option, but doesn't show it (something for later - private federeated conversation?)

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 19, 2024
@Antreesy Antreesy self-assigned this Mar 19, 2024
@Antreesy
fix(conversation): allow to invite federated user when creating a con…
c02ca12 
…versation

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy enabled auto-merge March 19, 2024 15:39
@Antreesy Antreesy merged commit cecbdac into main Mar 19, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/minor-federation branch March 19, 2024 15:42
@nickvergessen nickvergessen mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: federation 🌐 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Antreesy @nickvergessen