Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SharedItems): fetch after page reload + fix(Conversation): set warnings on max length #11868

Merged
merged 3 commits into from Mar 20, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 20, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if you show max length somewhere ( either in a counter or in error message) so if a user pastes a text, they can know how many characters they should reduce.

@Antreesy
Copy link
Contributor Author

I think it would be better if you show max length somewhere ( either in a counter or in error message) so if a user pastes a text, they can know how many characters they should reduce.

What about t('spreed', 'Maximum length is exceeded by ({length}) characters'), where {length} is a diff?

@DorraJaouad
Copy link
Contributor

DorraJaouad commented Mar 20, 2024

What about t('spreed', 'Maximum length is exceeded by ({length}) characters'), where {length} is a diff?

Let's not depend on that, diff can be get to extreme cases easily (100000000000000000) and won't look good

@Antreesy Antreesy force-pushed the fix/11433/note-to-self-spinner branch from b09573d to 66d1cab Compare March 20, 2024 11:50
@Antreesy Antreesy enabled auto-merge March 20, 2024 11:52
@Antreesy Antreesy disabled auto-merge March 20, 2024 11:54
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/11433/note-to-self-spinner branch from 66d1cab to d091484 Compare March 20, 2024 11:56
@Antreesy Antreesy enabled auto-merge March 20, 2024 11:56
@Antreesy Antreesy merged commit 94974dc into main Mar 20, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/11433/note-to-self-spinner branch March 20, 2024 12:03
@alexanderdd
Copy link

Thank you!

Is it possible to backport this to earlier Nextcloud versions like 28, 27?

@Antreesy
Copy link
Contributor Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants